[BE] socket 분리 로직 수정 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuuo3o
approved these changes
Nov 12, 2024
| @@ -22,7 +22,7 @@ import { RequestInterface } from './interface/request.interface'; | |||
| @Controller('/api/stocks/trade') | |||
| @ApiTags('주식 매수/매도 API') | |||
| export class StockOrderController { | |||
| constructor(private readonly stockTradeService: StockOrderService) {} | |||
| constructor(private readonly stockOrderService: StockOrderService) {} | |||
There was a problem hiding this comment.
🟢 이거 socket 분리 로직 수정 커밋 맞나요?? 소켓이랑 상관 없어보이는 코드 수정 같아 보이는데 커밋 나눠서 작성해주시면 더 좋을 거 같아요
There was a problem hiding this comment.
에고 그렇네요ㅜ 다음부터 유의해서 커밋 올리겠습니당
|
|
||
| @Injectable() | ||
| export class StockIndexSocketService extends BaseSocketService { | ||
| export class StockIndexSocketService { | ||
| private TRADE_CODE = 'H0UPCNT0'; |
There was a problem hiding this comment.
🟢 제 개인적인 취향을 말하자면,, 한투에서 TR_ID 라는 이름으로 값을 받고 있으면 여기서도 동일하게 작성하는게 예뻐보이는데 어떻게 생각하시나요..?!
There was a problem hiding this comment.
저도 그게 더 좋을 것 같네요! 수정해서 커밋 추가했습니다.
| (data: string[]) => { | ||
| this.socketGateway.sendStockIndexValueToClient( | ||
| this.STOCK_CODE[data[0]], | ||
| new StockIndexValueElementDto(data[2], data[4], data[9], data[3]), |
There was a problem hiding this comment.
🟢 여기도 위에 코스피, 코스닥 이런 주석 단 것처럼 data[2], data[4] 이런 값이 어떤건지 주석으로 달아두면 코드 읽기가 더 좋을 거 같아요!
There was a problem hiding this comment.
좋습니당 주석 추가해두었습니다~!
|
헉 수정이 짱 빠르시네요.. 감동! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 주요 작업
💭 고민과 해결과정